fix(ci): avoid pipefail in ci.yaml shell code - #2462
Open
juenglin wants to merge 1 commit into
Open
Conversation
Contributor
kkraus14
reviewed
Jul 31, 2026
kkraus14
left a comment
kkraus14
left a comment
Collaborator
There was a problem hiding this comment.
Two small inline notes.
| --jq '.[] | select(.name | startswith("cuda-core-v")) | .name' \ | ||
| | head -1)" | ||
| mapfile -t _tags < <(gh api "repos/$GITHUB_REPOSITORY/tags" --paginate \ | ||
| --jq '.[] | select(.name | startswith("cuda-core-v")) | .name' || true) |
Collaborator
There was a problem hiding this comment.
|| true masks every gh api failure, and mapfile cannot propagate a process-substitution status. A later pagination failure can therefore let this job continue after selecting a partial result. Please capture the command output normally before taking its first line.
Collaborator
There was a problem hiding this comment.
Suggested shape:
tags="$(gh api "repos/$GITHUB_REPOSITORY/tags" --paginate \
--jq '.[] | select(.name | startswith("cuda-core-v")) | .name')"
tag="${tags%%$'\n'*}"This consumes the output before selecting the first tag, avoids SIGPIPE, and keeps a gh api failure fatal under -e.
| @@ -257,9 +257,9 @@ jobs: | |||
| # --paginate fetches all pages; jq outputs one name per line per page; | |||
| # head -1 takes the first (newest) match since GitHub returns tags | |||
Collaborator
There was a problem hiding this comment.
This comment still says head -1 selects the tag. Please update it to describe selecting the first collected tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: ci failures like this
The CI failure is a classic SIGPIPE +
pipefailinteraction.The original code pipes
gh api --paginateintohead -1. Underbash -o pipefail(set by the shell option in the step), when
head -1reads one line and exits, itcloses the pipe.
gh apithen receives SIGPIPE (exit 141), andpipefailpropagatesthat non-zero exit code through the command substitution, causing the step to fail
under
set -e.The fix avoids this by:
mapfile(no pipe to break).|| trueto suppress any transientgh apiexit code from the process substitution.${_tags[0]:-}instead ofhead -1.